Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code not picking up Hasklig's ligatures. While KDevelop and KDE's font config utility do. #79

Closed
BobbyBabes opened this issue Nov 19, 2016 · 22 comments

Comments

@BobbyBabes
Copy link

BobbyBabes commented Nov 19, 2016

As per the title.
Do I need to take extra steps to get Hasklig working in VS Code?

VS Code not picking up Hasklig's ligatures. But the font is changed to Source Code Pro.
And also showing KDE's font config utility picking up Hasklig's ligatures without any issues.

hasklig-font-not-working-correctly-in-vscode_20161119_120623

On the exact same box, simultaneously, KDE's KDevelop is picking up Hasklig's ligatures without any issues.

hasklig-font-working-correctly-in-kdevelop_20161119_121105

Edit: And KWrite and Kate (also on the exact same box) picking up Hasklig's ligature's correctly.

hasklig-font-working-correctly-in-kwrite-and-kate_20161119_123529

@BobbyBabes BobbyBabes changed the title VS Code not picking up Hasklig's ligatures. While Kdevelop and KDE's font config utility do. VS Code not picking up Hasklig's ligatures. While KDevelop and KDE's font config utility do. Nov 19, 2016
@rune-ks
Copy link

rune-ks commented Nov 21, 2016

Make sure you have set "editor.fontLigatures": true in your settings.json file :)

screenshot from 2016-11-21 21-39-55

@BobbyBabes
Copy link
Author

BobbyBabes commented Nov 22, 2016

I forgot to mention that I had already set that to true (afterwards; i should have updated my comment).
It doesn't work out for me though. I'll be reinstalling Linux (again) tomorrow though. Maybe, just maybe.

hasklig-font-not-working-correctly-in-vscode_2016-11-22_18-58-40

@lstatie
Copy link

lstatie commented Nov 22, 2016

I tried to use Hasklig, the beta that supports the same ligatures as Fira
Code, and had the same results. For me the ligatures worked the first day,
and never again after.
I am now using Fira Code. Supposedly Hasklig uses the same engine, but
under Visual Studio 2015, that does not work. Fira Code works flawlessly
though.

Lorenzo Statie

On November 22, 2016 at 10:02:40 AM, BobbyBabes (notifications@github.com)
wrote:

I forgot to mention that I had already set that to true.
It doesn't work out for me though. I'll be reinstalling Linux (again)
tomorrow though. Maybe, just maybe.

[image: hasklig-font-not-working-correctly-in-vscode_2016-11-22_18-58-40]
https://cloud.githubusercontent.com/assets/22870070/20535649/f18bf7c0-b0e5-11e6-9c12-911f457172f9.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#79 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AStKVknLgygz_j-5Tpsgt-lhmPPLecNVks5rAy5AgaJpZM4K3OvU
.

@BobbyBabes
Copy link
Author

But I'm not using Visual Studio 2015.
I'm using Visual Studio Code on Linux.
I don't however know if that difference matters for font rendering.

@elaijuh
Copy link

elaijuh commented Dec 27, 2016

same here i just found ++, == works, but !==, -> doesn't work

@i-tu
Copy link
Owner

i-tu commented Jan 24, 2017

@BobbyBabes Has there been a change in this issue?

@BobbyBabes
Copy link
Author

BobbyBabes commented Jan 24, 2017

On my side the change was to use Fira as suggested by @lstatie . Works flawlessly.
I'm not aware of any changes in this repo regarding this (if you had made any that I should have noticed).

@lstatie
Copy link

lstatie commented Jan 24, 2017 via email

@i-tu
Copy link
Owner

i-tu commented Jan 24, 2017

Have you tried with version 1.1? It changed to use ligatures in a way similar to Fira

@stritti
Copy link

stritti commented Jan 24, 2017

I have currently installed the insider Version of Visual Studio Code for Windows (V. 1.9.0-insider, todays build) and the latest version of haslik.

Set following :
''''
"editor.fontFamily": "Hasklig",
"terminal.integrated.fontLigatures": true,
''''

But the ligatures are not shown.

DL VSC: https://code.visualstudio.com/docs/?dv=win&build=insiders

@BobbyBabes
Copy link
Author

BobbyBabes commented Jan 25, 2017

I just tried with Visual Studio Code. Still the same issues.
One box with ArchLinux + KDE. The other with ArchLinux + Deepin (tomorrow reinstalled with Gnome).
EDIT: I tried with v1.1 of course.

@fazilz
Copy link

fazilz commented Feb 20, 2018

So its been a year, and the issue still persists with VS Code and hasklig.

@MagBad
Copy link

MagBad commented Feb 20, 2018

It's working fine for me. Literature for ->, ==, etc. are shown.
Do you have the latest update? They've released a new version just a couple of weeks ago.

@fazilz
Copy link

fazilz commented Mar 8, 2018

ah I should've been clearer, some of them show up but not all, for example the ones that work are
->, == :: >> << and === but the some like != and !=== don't.

@Apostolique
Copy link

Apostolique commented Apr 14, 2018

I also just noticed that, some ligatures aren't picked up.

Edit: Actually, != and !=== are not implemented yet. @fazilz

The only stuff available are: <* <*> <+> <$> *** <| |> <|> !! || === ==> <<< >>> <> +++ <- -> => >> << >>= =<< .. ... :: -< >- -<< >>- ++ /= == and after testing, they all work.

@fazilz
Copy link

fazilz commented Apr 29, 2018

@Apostolique ok that certainly makes a lot more sense, thanks.

@SirPhemmiey
Copy link

This isn't still fixed yet, huh?

@leggomuhgreggo
Copy link

I was setting the font to "Hasklig" and switching to "Hasklig-Medium" did the trick

@maxtar
Copy link

maxtar commented Jan 14, 2019

Doesn't work for me too.

@mikeerickson
Copy link

I too am seeing the same issue with Hasklig (works fine with Dank Mono)

  • OSX 10.14.2
  • VSCode Version 1.31.0-insider (1.31.0-insider)
  • Used fontFamily of "Hasklig" or "Hasklig-Medium"
  • fontLigatures: true

image

@mroyce1
Copy link

mroyce1 commented Oct 21, 2019

Any updates on this? Issue still persists for me.

Hasklig 1.1
Ubuntu 19.04
VSC 1.39.2

@twwright
Copy link

Same issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests