Update typings to export I18NextRequest instead of extending global express Request #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachinman
approved these changes
Apr 17, 2020
|
Wondering if this should be released on a major, as it could possibly break TS builds? |
|
published in i18next-express-middleware@2.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @isaachinman , @jamuhl ,
As discussed within my previous PR, I created this one with updated typings.
#177
I had to replace in all my code req.t & req.language by (req as I18NextRequest).t and (req as I18NextRequest).language.
You may have people complain about this once merged but I guess this is the direction you would like to take for your typings.
Thanks,
Nicolas