Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove typeof window.document === 'undefined' check which deopt bundle optimization #137

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

felixmosh
Copy link
Contributor

@felixmosh felixmosh commented Apr 18, 2024

fixes #136

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • [] tests are included
  • commit message and code follows the Developer's Certification of Origin

with default bundle define config of typeof window === "object" in browser env the lib gets removed
image

@adrai adrai merged commit 6c6bea0 into i18next:master Apr 18, 2024
2 checks passed
@felixmosh felixmosh deleted the fix-136 branch April 18, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cross-fetch leaks to client-side bundle
2 participants