Dereference timers in node.js so that the process may exit when finished #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danthegoodman
commented
May 16, 2024
| resolve(true) | ||
| setTimeout(() => reject(new Error('timeout')), 1500) | ||
| }) | ||
| setTimeout(() => reject(new Error('timeout')), 1500).unref() |
Contributor
Author
There was a problem hiding this comment.
I moved this line so that it behaves as a proper timeout check against the backend.read call.
Contributor
Author
|
I didn't update the |
Member
|
thank you, it's included in v2.5.2 |
Contributor
Author
|
wow! So quick! Thank you 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the package in a node script is preventing the process from exiting because the reload interval timer has not been marked with
unref. This PR resolves that issue.For testing, I removed the
--exitflag that had been previously been forcing mocha to exit immediately even if timers or servers were still open. This also required all servers and timers to in tests to be unrefed as well.Checklist
npm run test