Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typings, to avoid "Critical dependency: the request of a dependency is an expression" error with builders #12

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

jy95
Copy link
Contributor

@jy95 jy95 commented Apr 6, 2024

#11

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@adrai adrai merged commit c35ed89 into i18next:main Apr 10, 2024
2 checks passed
@adrai
Copy link
Member

adrai commented Apr 10, 2024

thank you... it's included in v1.2.1

@jy95 jy95 deleted the patch-1 branch April 10, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants