Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): Handle a few more use cases of potential count attributes. #260

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

vincentdesmares
Copy link
Contributor

Our original problem is that: due to an upgrade of i18next version and a move to typescript, many of our plural uses-cases using the Trans component do not work anymore.

This pull request answers a few translations that are not taken in account with the current parser.

  • count={a.b}
  • count={a?.b}
  • count={a - 1}
  • count={a ? b : c}

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

Checklist (for documentation change)

  • only relevant documentation part is changed (make a diff before you submit the PR)
  • motivation/reason is provided
  • commit message and code follows the Developer's Certification of Origin

@vincentdesmares
Copy link
Contributor Author

@cheton Not sure why the Ci is not starting.

@vincentdesmares
Copy link
Contributor Author

It looks like the workflow is awaiting approval from a maintainer for the test to run 😢

@vincentdesmares
Copy link
Contributor Author

It looks like everything is green. Could you merge the PR @cheton ?

@cheton cheton merged commit 985e6de into i18next:master Jun 14, 2024
4 checks passed
@cheton
Copy link
Member

cheton commented Jun 14, 2024

@vincentdesmares Sorry for the delay. This change has been released in version 4.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants