fallbackLng as default lng

[ogarich89]

Why did you change the behavior in the patch version?

19.8.5 - "use fallbackLng as default lng"

After update, language is always taken from "fallbackLng"

The behavior can be viewed in this repository
https://github.com/ogarich89/iso/tree/feature/i18next

[adrai]

It's just a fallback behaviour if no language and language detector is defined...
Does this hurt you somehow?

[adrai]

btw: you may also define ru as fallbackLng here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

[ogarich89]

btw: you may also define ru as fallbackLng here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

I define language here: https://github.com/ogarich89/iso/blob/feature/i18next/src/server/middleware/i18next.ts#L24

Before version 19.8.5 everything worked fine

[adrai]

The problem is this: https://github.com/ogarich89/iso/blob/feature/i18next/src/server/middleware/i18next.ts#L13
fallbackLng = 'ru'

You are defining a fallbackLng, but i18next does not know this... it know 'en' from here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

in init it is 'en' and outside of i18next you define 'ru' and call changeLanguage afterwards...

So if you want ru to be the fallbackLng i18next needs to know it here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

The i18nextMiddleware only runs on server side, so I suspect there is some sort of timing issue

[adrai]

I suspect the changeLanguage call is done before i18next has finished to initialize

[ogarich89]

The problem is this: https://github.com/ogarich89/iso/blob/feature/i18next/src/server/middleware/i18next.ts#L13
fallbackLng = 'ru'

You are defining a fallbackLng, but i18next does not know this... it know 'en' from here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

in init it is 'en' and outside of i18next you define 'ru' and call changeLanguage afterwards...

So if you want ru to be the fallbackLng i18next needs to know it here: https://github.com/ogarich89/iso/blob/feature/i18next/src/shared/libs/i18n.ts#L11

The i18nextMiddleware only runs on server side, so I suspect there is some sort of timing issue

It did not help =(

[adrai]

what did not help?
Did you change the code to wait for i18next to initialize before calling changeLanguage?

[ogarich89]

Before update i18next

before.mov

After update to 19.8.5

after.mov

[ogarich89]

what did not help?
Did you change the code to wait for i18next to initialize before calling changeLanguage?

i18next.isInitialized return true before call changeLanguage

[adrai]

on server side probably it's initialized, but on client side I don't think so

[ogarich89]

Client side: https://github.com/ogarich89/iso/blob/feature/i18next/src/client/index.tsx#L29

[adrai]

Should be better with v19.8.8