Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resource and default namespace typings #1240

Conversation

JCQuintas
Copy link
Contributor

Description

Export the Resources and DefaultNamespace types from react-i18next to allow for proper typing of the useTranslation and serverSideTranslations functions as described on react-i18next documentation

I've added documentation, but I'm not sure that is the better place for it.

@vercel
Copy link

vercel bot commented Jun 4, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/isaachinman/next-i18next/8DsEd5pz8f32imA3G7eQai28sQYE
✅ Preview: https://next-i18next-git-fork-jcquintas-fix-resource-and-defau-ec0d91.vercel.app

@JCQuintas
Copy link
Contributor Author

Maybe we should wait for my other MR to land on react-i18next here: i18next/react-i18next#1328 before we merge this to offer a more complete solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants