Merge pull request #1224 from pcorpet/array-type

Accept const components prop for Trans.
i18next · Dec 14, 2020 · 6e9a17a · 6e9a17a
2 parents 59758d4 + 7de332c
commit 6e9a17a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/index.d.ts b/src/index.d.ts
@@ -33,7 +33,7 @@ export interface TransProps<E extends Element = HTMLDivElement>
   extends React.HTMLProps<E>,
     Partial<WithT> {
   children?: React.ReactNode;
-  components?: readonly React.ReactNode[] | { [tagName: string]: React.ReactNode };
+  components?: readonly React.ReactNode[] | { readonly [tagName: string]: React.ReactNode };
   count?: number;
   defaults?: string;
   i18n?: i18n;

diff --git a/src/ts4.1/index.d.ts b/src/ts4.1/index.d.ts
@@ -118,7 +118,7 @@ export interface TransProps<
   E extends Element = HTMLDivElement
 > extends React.HTMLProps<E> {
   children?: React.ReactNode;
-  components?: React.ReactNode[] | { [tagName: string]: React.ReactNode };
+  components?: readonly React.ReactNode[] | { readonly [tagName: string]: React.ReactNode };
   count?: number;
   defaults?: string;
   i18n?: i18n;

diff --git a/test/typescript/Trans.test.tsx b/test/typescript/Trans.test.tsx
@@ -26,6 +26,13 @@ function objectComponents() {
   return <Trans components={{ Btn: <button /> }} defaults="Hello <Btn />" />;
 }
 
+function constObjectComponents() {
+  const constObject = {
+    Btn: <button />,
+  } as const;
+  return <Trans components={constObject} defaults="Hello <Btn />" />;
+}
+
 function count() {
   return <Trans count={42}>Foo</Trans>;
 }