fix: typescript definition of context object #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosskevin
suggested changes
Aug 18, 2020
There was a problem hiding this comment.
Thanks @seanplwong, please add a usage test to the test/typescript directory to exercise it and prevent regressions in the future.
rosskevin
changed the title
Wrap I18nContext value in an object - add test for typedef
|
In fact I could help get some types generated at build time later, so that manual maintenance on types could be reduced |
rosskevin
approved these changes
Aug 20, 2020
|
Thanks @seanplwong, @jamuhl this can be a patch release |
|
published in react-i18next@11.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap I18nContext value in an object
FIX: i18next/next-i18next#799
FIX: i18next/next-i18next#789
Checklist
npm run test