-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: unescape html in Trans #1426
Conversation
Not sure if this should be an optional behaviour - can't really guess if there are side effects on existing projects? @adrai what do you think? |
The content should escape when extracting Trans content, but I do not use saveMissing. It may be a breaking change unless you can share translation memory between escaped and unescaped versions. |
my gut feeling says, this should only be introduced with a new Trans prop (and/or react option) that enables this |
@cuyl can you adapt the PR accordingly? |
@adrai Sure, please check it out |
@jamuhl lgtm (maybe also a react init option?) |
@adrai lgtm...guess react init option could be added in a later stage if really used that often? |
published in react-i18next@11.15.0 |
fixes #1424