Update macro to wrap defaults in brackets when necessary #1472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Trans macro generates invalid code when children contains a double quote. From ast explorer:
According to the JSX spec this isn't valid; JSX doesn't support any kind of escaping inside of
"
quoted attributes. Babel, tsc, prettier, etc all fail when parsing. To get around this we can just wrap the value in brackets. I made it only happen when the string in question contains a quote.I am kinda confused about how this is working today without issue.
I think we could also
defaults.replace(/"/g, """)
instead if that's preferred.Checklist
npm run test