Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset t when keyPrefix is updated. #1544

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Conversation

halouvi
Copy link
Contributor

@halouvi halouvi commented Aug 15, 2022

Reseting t when keyPrefix is changed
Fixes #1542

Checklist

  • only relevant code is changed (make a diff before you submit the PR)
  • run tests npm run test
  • tests are included
  • commit message and code follows the Developer's Certification of Origin

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.862% when pulling aef6a37 on halouvi:master into ef3b87a on i18next:master.

@adrai adrai requested a review from jamuhl August 15, 2022 10:58
@jamuhl
Copy link
Member

jamuhl commented Aug 15, 2022

lgtm

@halouvi
Copy link
Contributor Author

halouvi commented Aug 15, 2022

Thanks! I really appreciate you guys working so fast 🙏

@adrai adrai merged commit c06710c into i18next:master Aug 15, 2022
@adrai
Copy link
Member

adrai commented Aug 15, 2022

Thank you @halouvi for your contribution. It's included in v11.18.4

If you like this module don’t forget to star this repo. Make a tweet, share the word or have a look at our https://locize.com to support the devs of this project.

There are many ways to help this project 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

t is not refreshed when keyPrefix is changed
4 participants