Added conditional warning on unmatched variable during interpolation #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I mentioned in #157 that it would be nice to receive a warning if no matching prop was provided during interpolation. I noticed that if you use
i18n.t
to try and translate a value that has a variable in it you get the following warningI added a basic conditional check that
this.props[match]
actually exists. If it doesn't it callsthis.i18n.services.logger.warn
and essentially mimic the exact same behavior as if you had used that translation with just the standardi18n.t
function.First, I appreciate the work you guys have done. This is definitely the most enjoyable i18n software I have found. Second, I have not committed to OSS much, so forgive me if this is a naive solution. If you have any feedback I will gladly improve on this.