Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reportNS function to I18NextProvider to report used namespaces #500

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Added reportNS function to I18NextProvider to report used namespaces #500

merged 1 commit into from
Aug 24, 2018

Conversation

olivierpascal
Copy link
Contributor

Related to #499

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.937% when pulling d398635 on olivierpascal:reportNS into 2d2ec21 on i18next:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 82.937% when pulling d398635 on olivierpascal:reportNS into 2d2ec21 on i18next:master.

@jamuhl
Copy link
Member

jamuhl commented Aug 24, 2018

Looks good...would you also be able to extend the documentation?!?:

-> https://react.i18next.com/components/i18nextprovider#the-i-18-nextprovider-props (add the new prop)
-> https://react.i18next.com/misc/serverside-rendering add a small sample (like in your issue description to show how to use this new feature)

@olivierpascal
Copy link
Contributor Author

Sure!

@jamuhl
Copy link
Member

jamuhl commented Aug 24, 2018

thanks again

published in react-i18next@7.11.0

@tutok
Copy link

tutok commented Aug 31, 2018

it looks like namespace reported by reportNS is undefined when no namespace is specified and fallback rule is executed. For example when I use translate HOC in that way: translate()(Home);

@olivierpascal
Copy link
Contributor Author

Maybe you can create an issue (please tag me) and use something like yourArray.filter(Boolean) until a fix is available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants