Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

related to issue #504: also report default Namespace with translate() #506

Merged
merged 1 commit into from
Sep 3, 2018
Merged

related to issue #504: also report default Namespace with translate() #506

merged 1 commit into from
Sep 3, 2018

Conversation

olivierpascal
Copy link
Contributor

I also chose to report undefined when no namespace is used with translate() and no default namespace is defined in options.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 82.937% when pulling afc3a5c on olivierpascal:reportDefaultNamespace into b702d54 on i18next:master.

@jamuhl jamuhl merged commit 1cba999 into i18next:master Sep 3, 2018
@olivierpascal olivierpascal deleted the reportDefaultNamespace branch September 3, 2018 15:03
@jamuhl
Copy link
Member

jamuhl commented Sep 3, 2018

thanks again - was published in react-i18next@7.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivierpascal @coveralls @jamuhl