Fix hooks being called conditionally in useTranslation

[onestopjs]

In the useTranslation hook, useContext is called conditionally, which breaks the Rule of Hooks, so it may cause problems in the future. This fixes it by calling useContext on every render, just not always using the result from it.

[onestopjs]

This is a fix for #934

[coveralls]

Coverage increased (+0.01%) to 95.202% when pulling 3d2361f on PsychedMagnet:patch-1 into f41a24b on i18next:master.

[jamuhl]

Guess that will work - and also not against a merge.

But I would love to know how this can happen. The result from getHasUsedI18nextProvider() is always the same depending of using I18nextProvider or not, so how could there be a change of order? Only way i could think of is nesting I18nextProvider inside a useTranslation|withTranslation ?!?

[onestopjs]

Oh, you are right. There is a goof up on my part - I was calling useTranslation above I18nextProvider. I will definitely fix this, thank you! :)

Anyways, I think unconditionally calling useContext is the better option as a good practice either way.

[jamuhl]

published in react-i18next@10.12.3