Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add t function to TransProps types #969

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Add t function to TransProps types #969

merged 2 commits into from
Oct 23, 2019

Conversation

valgussev
Copy link
Contributor

@valgussev valgussev commented Oct 18, 2019 •
edited
Loading

It seems t function is currently missing from types, let's add it back

@coveralls
Copy link

coveralls commented Oct 18, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 95.642% when pulling 0c874c1 on valerii-cognite:transprops-t into 05b3e4d on i18next:master.

@jamuhl jamuhl requested a review from rosskevin October 18, 2019 07:08
rosskevin
rosskevin suggested changes Oct 18, 2019
View reviewed changes
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a usage test in test/typescript to prevent future regressions

@valgussev
Copy link
Contributor Author

@rosskevin added

rosskevin
rosskevin approved these changes Oct 23, 2019
View reviewed changes
Copy link
Collaborator

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you @valerii-cognite

@rosskevin rosskevin merged commit 8d84b7d into i18next:master Oct 23, 2019
@rosskevin
Copy link
Collaborator

@jamuhl this can be a patch release

@jamuhl
Copy link
Member

jamuhl commented Oct 24, 2019

published in react-i18next@10.13.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@valgussev @coveralls @rosskevin @jamuhl