Adding format_down option to path_exists and run_watch #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,6 +259,8 @@ to the config section. | |||
| Expands the given path to a pidfile and checks if the process ID found inside | |||
| is valid (that is, if the process is running). You can use this to check if | |||
| a specific application, such as a VPN client or your DHCP client is running. | |||
| It also exists an option "format_down". You can hide the output with | |||
There was a problem hiding this comment.
“It also exists” is a german idiom that doesn’t translate directly to english. Use “There also is” instead. Also, please replace the quotes with +, i.e. +format_down=""+ to be consistent with the rest of this manpage.
|
Please squash your commits into one commit so that we have a clean history. Also, please add “fixes #1” to the commit description so that the issue will automatically be closed. |
|
Squashed it. |
stapelberg
added a commit
that referenced
this pull request
Apr 2, 2015
Adding format_down option to path_exists and run_watch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #1 the option format_down (to hide the output) is missing on path_exists. This also add the option to run_watch.
Do not change behavior without editing config, so no user will claim the new optional behaviour!