Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences / Web App #79

Merged
merged 44 commits into from
Jun 24, 2023
Merged

Preferences / Web App #79

merged 44 commits into from
Jun 24, 2023

Conversation

iBicha
Copy link
Owner

@iBicha iBicha commented Jun 10, 2023

  • Preferences web api to able to change user prefs
  • Preferences are also available from TV
  • Idea inspired from jellyfin

This will lay the ground of settings things up for playback settings, invidious, sponsorblock, etc

Settings

  • Make sure different parts of the app do not start loading settings before the settings are ready
  • remove a couple of unused classes
  • implement visibility? => let's skip that, just set type (tv/web)
  • Delete old settings is applicable (like array of instances for invidious)
  • Hook settings into app
    • auto play: if off, exit video on end
    • preferred quality: sort video streams by this preference
    • Invidious proxy video
    • SponsorBlock: enabled / show notifications
  • Buttons!
    • History -> search history -> clear
  • Implement the settings for the web app Web app #80
  • Move qrcode view out of settings

Web app (#80 )

  • better state caching
    • Lazy loading for images
    • No component unmount
  • Fix VideoCell layout
  • Fix search dropdown and search
  • Carousel and theme
  • search by video id
  • Share search history with app
  • On Video click, modal to play video
    • Two buttons, play on Roku or play on Invidious (open in new tab)
    • Use device name ifDeviceInfo .GetFriendlyName
    • Fix modal layout on phone
  • Finish video cell (time, live indicator, premiere, etc)

Stuff from v1

  • Drag n drop links
  • Clear search history
  • Dev menu
    • Hidden via url
    • Can change playlet lib version
    • Fetches releases from Github

Deferred

  • Setting controls should not have "instant save" to avoid accidental changes (on the web)
  • Buttons!
    • Invidious -> User -> logout (and display username?)
    • Reset settings? -> low priority, not for now
  • better state caching
    • Use etag headers to cache files
  • Error handling of web requests

iBicha and others added 27 commits May 19, 2023 18:49
* Update instance stuff

* Update dependencies

* Add basic layout

* Info and settings page, missing styling

* Navbar fixes

* Settings page formatting

* Theme stuff

* Feedback link

* Fix username badge

* Fix svelte warnings

* A wip search page

* Add a couple of api functions

* Wip home screen

* user country code

* Expose token and proxy auth calls

* Use auth requests server side

* Some cleanup

* Add svelte vs code extension

* remove old web app

* More layout stuff

* Tweak for string control

* Filter out old search suggestions

* Search history stuff

* img size for lazy loading

* Basic modal to play video
@iBicha iBicha changed the title Feature/preferences api Preferences / Web App Jun 23, 2023
github-action linter and others added 2 commits June 23, 2023 15:52
@iBicha iBicha mentioned this pull request Jun 24, 2023
@iBicha iBicha marked this pull request as ready for review June 24, 2023 19:32
@iBicha iBicha merged commit 8f8c7d3 into main Jun 24, 2023
@iBicha iBicha deleted the feature/preferences-api branch June 24, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant