-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue 1994 #2000
fix: issue 1994 #2000
Conversation
Starting with the version 28.0.3 of the Android SDK build tools, the internal ids of the items of an array bag seems to have changed. Because of those changes, array resources were no longer decoded correctly. They were decoded as style resources. Instead of using the id of the first item within a resource bag, the name of the res type spec is now used to choose the correct resource bag value to create. Note: a list of "legal names" for resource types can be found in the source code of aapt2.
Lucky #2000 :) Everything looks good. If you wouldn't mind pushing the example app source code here - https://github.com/iBotPeaches/TestApks Allows me to easily rebuild those applications if needed |
Sure! Here is the PR for the source code of the test apk: iBotPeaches/TestApks#2 |
Thanks for the PR and very detailed commits. Makes it real easy for me! |
You're welcome :) Thanks a lot for all the work you have put into this project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
I have separated the changes into two commits:
Note: for now I have kept the previous check on the id of the first item within the bag.
Note: I'm not 100% sure that the same technique could be applied to the
attr
resources. For now, only thestyle
,plurals
, andarray
have a new check on the res type spec name.