Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decoding references to private resources #2650

Merged
merged 3 commits into from
Oct 17, 2021
Merged

fix: decoding references to private resources #2650

merged 3 commits into from
Oct 17, 2021

Conversation

MrIkso
Copy link
Contributor

@MrIkso MrIkso commented Sep 7, 2021 •
edited by iBotPeaches
Loading

fixed #2033, fixed #2637 of error
error: resource <name> is private.
Use * before resource name if rererence to private resources.
Expample:
before fix
<color name="gm3_ref_palette_dynamic_tertiary900">@android:color/Indigo_700</color>
after fix
<color name="gm3_ref_palette_dynamic_tertiary900">@*android:color/Indigo_700</color>

@MrIkso MrIkso mentioned this pull request Sep 7, 2021
Closed
@iBotPeaches
Copy link
Owner

Approved the workfun to run. I remember reverting this fix a few years ago because I improperly added it to ALL resources, this seems like a safer version.

iBotPeaches
iBotPeaches previously approved these changes Sep 9, 2021
View reviewed changes
@iBotPeaches
Copy link
Owner

Do you have a good idea of a way we can test this in our test suite? Like finding a resource that should remain private and adding it to colors.xml? Then testing to make sure it comes out with the asterisk?

@iBotPeaches
Copy link
Owner

@MrIkso ping here. I am curious if you have a good idea for a test so we don't regress this.

@MrIkso MrIkso dismissed stale reviews from RachelZoieJovie97 and iBotPeaches via 33f6d46 October 13, 2021 20:14
@MrIkso
Copy link
Contributor Author

MrIkso commented Oct 13, 2021

@iBotPeaches even thought of this for the test...

@iBotPeaches iBotPeaches merged commit d294111 into iBotPeaches:master Oct 17, 2021
@iBotPeaches
Copy link
Owner

thanks!

@pashamcr
Copy link
Contributor

pashamcr commented Oct 18, 2021 •
edited
Loading

This is fixed in aapt/aapt2 https://github.com/pashamcr/AAPTS/tree/windows, and works without this fix with #2637 ,
apk file #2033 I didn't find one to check. Here's for aapt's for Windows test
aapt_64.exe.txt
aapt2_64.exe.txt
:

sakibguy added a commit to sakibguy/Apktool that referenced this pull request Oct 19, 2021
@sakibguy
Merge pull request #8 from iBotPeaches/master
bfc6b05 
fix: decoding references to private resources (iBotPeaches#2650)
@FriendlyNeighborhoodShane FriendlyNeighborhoodShane mentioned this pull request Jan 20, 2022
Closed
@starbucks2010 starbucks2010 mentioned this pull request Mar 6, 2022
Closed
iBotPeaches added a commit that referenced this pull request Mar 21, 2022
@iBotPeaches
Revert "fix: decoding references to private resources (#2650)"
a5546ee 
This reverts commit d294111.
@iBotPeaches iBotPeaches mentioned this pull request Mar 21, 2022
Merged
@iBotPeaches iBotPeaches mentioned this pull request Sep 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iBotPeaches iBotPeaches iBotPeaches approved these changes

@RachelZoieJovie97 RachelZoieJovie97 RachelZoieJovie97 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Can't roundtrip gboard error: Error: Resource is not public.
4 participants
@MrIkso @iBotPeaches @pashamcr @RachelZoieJovie97