Remove Apktool Dummys. #3258
Merged
Remove Apktool Dummys. #3258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
added a commit
that referenced
this pull request
Sep 3, 2023
This reverts commit 0e22692.
iBotPeaches
added a commit
that referenced
this pull request
Sep 4, 2023
This reverts commit 0e22692.
iBotPeaches
added a commit
that referenced
this pull request
Sep 9, 2023
* Revert "Remove Apktool Dummys. (#3258)" This reverts commit 0e22692. * feat: properly add dummys * refactor: shorten ResTypeSpec * style: remove extra space * refactor: extract FlagItem into own class * refactor: notate which type is null * fix: only add dummys if enabled * feat: skip unknown (if enabled) * feat: introduce "res-mode" * feat: expose config on res table * feat: add method to base attr for res skips * fix: ensure autobuild doesn't choke * refactor: remove java17 enhanced switch * refactor: rename methods * refactor: cleanup res-mode param * test: introduction of test/sample apk * refactor: make ResXmlPatcher public for loading XML * test: assertions for dummy|leave|retain * fix: prevent using `@null` as a name * refactor: shorten long param for 'resm' * refactor: leave for preserve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First requested by @MrIkso a few years ago in #2463. It was recently broken a few releases back during the sparse resource fixes.
No one really noticed that these were missing and it turns out in a variety of tests - you don't really need them. All they do is bloat codebase, bloat application and unneeded. I may be proven wrong quickly after the removal of this, but since it actually hasn't been working in a year - I think its fair to say no one needs this.