Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary workaround of skipping unresolvable resources #3309

Closed
wants to merge 1 commit into from

Conversation

iBotPeaches
Copy link
Owner

refs: #2836


This is a workaround where we toss any bag/flag item where we can't resolve the reference. This pattern we keep during serialization of styles.

@iBotPeaches iBotPeaches changed the title fix: temporary workaround of skipping dummy resources fix: temporary workaround of skipping unresolvable resources Sep 3, 2023
@iBotPeaches
Copy link
Owner Author

iBotPeaches commented Sep 3, 2023

In comparison to #3312 this has similar issues.

➜  2836 apktool b Kate --use-aapt2
Picked up _JAVA_OPTIONS: -Dawt.useSystemAAFontSettings=on -Dswing.aatext=true
I: Using Apktool v2.8.1-54-06c5f462-SNAPSHOT
I: Checking whether resources has changed...
I: Building resources...
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/abc_select_dialog_material.xml:2: error: attribute paddingBottomNoButtons (aka com.perm.kate:paddingBottomNoButtons) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/abc_select_dialog_material.xml:2: error: attribute paddingTopNoTitle (aka com.perm.kate:paddingTopNoTitle) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/design_bottom_sheet_dialog.xml:6: error: attribute layout_behavior (aka com.perm.kate:layout_behavior) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/google_maps.xml:5: error: attribute uiZoomControls (aka com.perm.kate:uiZoomControls) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/header.xml:2: error: attribute layout_scrollFlags (aka com.perm.kate:layout_scrollFlags) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout/main.xml:9: error: attribute layout_behavior (aka com.perm.kate:layout_behavior) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout-v17/abc_select_dialog_material.xml:2: error: attribute paddingBottomNoButtons (aka com.perm.kate:paddingBottomNoButtons) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout-v17/abc_select_dialog_material.xml:2: error: attribute paddingTopNoTitle (aka com.perm.kate:paddingTopNoTitle) not found.
W: /media/ibotpeaches/AOSP/Apktool/2836/Kate/res/layout-v21/header.xml:2: error: attribute layout_scrollFlags (aka com.perm.kate:layout_scrollFlags) not found.
W: error: failed linking file resources.
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_23294930899700484038566146245785541628.tmp, link, -o, /tmp/APKTOOL4978815167123175357.tmp, --package-id, 127, --min-sdk-version, 16, --target-sdk-version, 33, --version-code, 542, --version-name, 104.1, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, --no-compile-sdk-metadata, -e, /tmp/APKTOOL10801113564464921474.tmp, -0, arsc, -I, /home/ibotpeaches/.local/share/apktool/framework/1.apk, --manifest, /media/ibotpeaches/AOSP/Apktool/2836/Kate/AndroidManifest.xml, /media/ibotpeaches/AOSP/Apktool/2836/Kate/build/resources.zip]
➜  2836

@iBotPeaches iBotPeaches closed this Sep 4, 2023
@iBotPeaches iBotPeaches deleted the issue-2836-temp branch September 4, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant