Merge pull request #232 from iCHEF/feature/upgrade_dev_deps

Upgrade dev dependencies
iCHEF · Sep 12, 2019 · c2837f5 · c2837f5
2 parents c47b1f3 + 95f4e3c
commit c2837f5
Show file tree

Hide file tree

Showing 7 changed files with 837 additions and 732 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -35,6 +35,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Changed
 - [Core] Update `<Section>` title style and increase bottom margin.
+- [Core] Remove the only test cases that uses `sinon`; remove `sinon` from dev dependencies.
 - [Form] Update `<SelectRow>` and `<SwitchRow>` to adpat vertically-reversed appearance as `<TextInputRow>` in v3.0.
 - [Form] Add `desc` prop to `<SelectOption>`
 - [Storybook] Update examples for refactord `<ColumnView>` and `<Modal>`.
@@ -43,7 +44,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - [Build] Upgrade to Babel v7.4.4 + `core-js` v3 to provide better polyfilling.
 - [Build] Upgrade to Lerna v3.16.4; changes publish steps.
 - [Build] Upgrade to `node-sass@4.12.0` for Node v10+ support.
-- [Build] Upgrade dependencies to address security alerts.
+- [Build] Upgrade to `stylelint@^10.0`, `autoprefixer@^9.6` and `postcss-loader@^3` for better CSS support.
+- [Build] Upgrade other dev dependencies to address security alerts.
 
 ## [3.0.0]
 ### Breaking

diff --git a/package.json b/package.json
@@ -36,7 +36,7 @@
     "@babel/preset-react": "^7.0.0",
     "@babel/runtime": "^7.4.4",
     "@babel/runtime-corejs3": "^7.4.4",
-    "autoprefixer": "^7.2.5",
+    "autoprefixer": "^9.6.1",
     "babel-core": "7.0.0-bridge.0",
     "babel-eslint": "^10.0.1",
     "babel-jest": "^23.6.0",
@@ -60,14 +60,14 @@
     "jest": "^23.6.0",
     "lerna": "^3.16.4",
     "node-sass": "^4.12.0",
-    "postcss-loader": "^2.0.10",
+    "postcss-loader": "^3.0.0",
     "prop-types": "^15.6.2",
     "react": "^16.6.3",
     "react-dom": "^16.6.3",
     "react-test-renderer": "^16.6.3",
     "sass-loader": "^6.0.2",
     "style-loader": "^0.19.1",
-    "stylelint": "^7.10.1",
+    "stylelint": "^10.1.0",
     "stylelint-config-standard": "^16.0.0",
     "webpack": "^3.10.0"
   },

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -48,7 +48,6 @@
     "@babel/cli": "^7.4.4",
     "enzyme": "^3.7.0",
     "react-is": "^16.6.1",
-    "sinon": "^4.0.1",
     "webpack": "^3.10.0",
     "webpack-merge": "^4.1.2"
   }

diff --git a/packages/core/src/__tests__/IconButton.test.js b/packages/core/src/__tests__/IconButton.test.js
@@ -1,7 +1,6 @@
 import React from 'react';
 import ReactDOM from 'react-dom';
 import { shallow } from 'enzyme';
-import { stub, assert } from 'sinon';
 
 import Button from '../Button';
 import IconButton from '../IconButton';
@@ -43,29 +42,4 @@ describe('<IconButton>', () => {
         expect(wrapper.hasClass('gyp-button--tinted')).toBeTruthy();
         expect(wrapper.hasClass('other-custom-class')).toBeTruthy();
     });
-
-    describe('invalid propTypes', () => {
-        let consoleStub;
-        beforeEach(() => {
-            consoleStub = stub(console, 'error');
-        });
-
-        afterEach(() => {
-            consoleStub.restore();
-        });
-
-        it('color must be empty', () => {
-            const wrapper = shallow(<IconButton icon="printer" color="red" />);
-
-            assert.calledWithMatch(consoleStub, /Failed prop type: <IconButton> must not contains color./);
-            expect(wrapper.find(Button).prop('color')).toBeUndefined();
-        });
-
-        it('solid must be empty', () => {
-            const wrapper = shallow(<IconButton icon="printer" solid />);
-
-            assert.calledWithMatch(consoleStub, /Failed prop type: <IconButton> must not contains solid./);
-            expect(wrapper.find(Button).prop('solid')).toBeUndefined();
-        });
-    });
 });
diff --git a/packages/core/src/styles/EditableBasicRow.scss b/packages/core/src/styles/EditableBasicRow.scss
@@ -81,4 +81,3 @@ $block-name: #{$prefix}-editable-basic-row;
         color: inherit;
     }
 }
-
diff --git a/packages/core/src/styles/HeaderRow.scss b/packages/core/src/styles/HeaderRow.scss
@@ -29,4 +29,3 @@ $component: #{$prefix}-header-row;
         overflow: hidden;
     }
 }
-
Original file line number	Diff line number	Diff line change
Expand Up		@@ -81,4 +81,3 @@ $block-name: #{$prefix}-editable-basic-row;
		color: inherit;
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -29,4 +29,3 @@ $component: #{$prefix}-header-row;
		overflow: hidden;
		}
		}