Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise deploy steps #105

Merged
merged 5 commits into from
Oct 26, 2017
Merged

Revise deploy steps #105

merged 5 commits into from
Oct 26, 2017

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Oct 26, 2017

Summary

This PR tries to use native deploy stage on Travis CI by using its script provider.

Releasing a new version now require you to run yarn bumpversion locally before submitting a release PR. It will update all package.json under packages/, commit those changes and tag it with a version tag.

Travis CI will run yarn release on master to only publish packages to npm.

@zhusee2 zhusee2 requested a review from cjies October 26, 2017 02:18
Copy link
Contributor

@cjies cjies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say goodbye to deploy.sh XDDD

.travis.yml Outdated
@@ -15,6 +15,8 @@ install:
before_script:
- yarn flow
- yarn lint

script:
Copy link
Contributor

@cjies cjies Oct 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If test break on script, will it continue the rest processes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to this doc, I believe it's “yes”.
Or I was thinking to move coverall to after_success so it only runs after tests passed?

@zhusee2 zhusee2 force-pushed the feature/zhusee_revise_deploy branch from 20338ce to 5d9ba64 Compare October 26, 2017 03:28
@zhusee2
Copy link
Contributor Author

zhusee2 commented Oct 26, 2017

Rebased with latest develop

@zhusee2 zhusee2 merged commit 56efd2c into develop Oct 26, 2017
@zhusee2 zhusee2 deleted the feature/zhusee_revise_deploy branch October 26, 2017 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants