Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closable() blocking children events #114

Merged
merged 4 commits into from
Nov 1, 2017

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Nov 1, 2017

Summary

Some click events are blocked if they are fired from components inside a closable() HOC, if the later is configured to close on inside clicks. The main reason if because the component is removed from React virtual DOM tree by the onClose callback triggered on closable().

Solution

Always delay onClose() callback for closable() HOC for both clicks and touches.

@zhusee2 zhusee2 added the bug label Nov 1, 2017
@zhusee2 zhusee2 merged commit 40ea576 into develop Nov 1, 2017
@zhusee2 zhusee2 deleted the bugfix/zhusee_fix_closable_blocking_events branch November 1, 2017 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants