Reduce useless render calls in 'closable()' mixin #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`clickedInside` and `closeDelayTimeout` are only used inside internal event listeners to determine if an outside-click event can be ignored if an inside-click event has already scheduled a close callback. They were previously put inside component states, therefore triggers useless `render()` calls as they change while they never affect render results. Moving them to instance variables saves a few calls to `render()`.
zhusee2
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
clickedInsideandcloseDelayTimeoutare only used inside internal event listeners to determine if an outside-click event can be ignored when an inside-click event has already scheduled a close callback.They were previously put inside component states, therefore triggers useless
render()calls as they change while they never affect render results.Moving them to instance variables saves a few calls to
render().