Enhance <TextInputRow> for custom rendering and textarea autosizing #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhusee2
reviewed
Mar 25, 2019
packages/form/src/TextInputRow.js
Outdated
| {...sharedProps} | ||
| {...inputProps} /> | ||
| return React.createElement( | ||
| isFunction(inputComponent) ? inputComponent : 'input', |
There was a problem hiding this comment.
Maybe you can just set default value of 'input' to props.inputComponent? And allow it to be either a String or a Function.
zhusee2
reviewed
Mar 25, 2019
| {...sharedProps} | ||
| {...inputProps} /> | ||
| ); | ||
| if (isFunction(renderInput)) { |
There was a problem hiding this comment.
What if it's used this way:
<TextInputRow
multiLine
renderInput={func}
/>Do you intent to let renderInput overridden by multiLine?
There was a problem hiding this comment.
No, input can't be customized when multiLine mode.
zhusee2
reviewed
Mar 25, 2019
| expect(controlledWrapper.find('textarea').prop('style')).toEqual({ height: 60 }); | ||
| const textareaWrapper = uncontrolledWrapper.find(AutoSizeTextarea); | ||
| expect(textareaWrapper.exists()).toBeTruthy(); | ||
| expect(textareaWrapper.props()).toMatchObject({ minRows: 5, maxRows: 10 }); |
zhusee2
approved these changes
Mar 25, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enhance
<TextInputRow>for custom rendering and textarea autosizing.Changes
Changed
<TextInputRow>:renderInputorinputComponentprop.minRowsandmaxRowsprops.Risk
none.
TODOs
none.