Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upgrade storybook #236

Merged
merged 4 commits into from
Nov 28, 2019
Merged

Feature/upgrade storybook #236

merged 4 commits into from
Nov 28, 2019

Conversation

benny0642
Copy link
Contributor

Purpose

Upgrade Storybook to v5.2.6

Changes

  1. upgrade storybook to v5.2.6
  2. set sourceType: unambiguous for babel-loader to workaround ES module import commonJS module. (ref: Error: exports is not defined storybookjs/storybook#3346 (comment))
  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

kyoyadmoon
kyoyadmoon approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@kyoyadmoon kyoyadmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhusee2
zhusee2 approved these changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benny0642 benny0642 merged commit 6f9fbe0 into develop Nov 28, 2019
@zhusee2 zhusee2 deleted the feature/upgrade-storybook branch January 22, 2020 02:59
@kyoyadmoon kyoyadmoon mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tz5514 tz5514 tz5514 left review comments

@kyoyadmoon kyoyadmoon kyoyadmoon approved these changes

@zhusee2 zhusee2 zhusee2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benny0642 @zhusee2 @kyoyadmoon @tz5514