Revamp core components storybook doc(pt. 5) #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anchored popover has wrong `top` position after we migrate to new addon-docs. Needs investigation.
chenesan
changed the title
2 tasks
zhusee2
approved these changes
Feb 11, 2020
chenesan
changed the base branch from
feature/core-docs-pt4
to
project/update-core-components-storybook-doc
tz5514
approved these changes
Feb 14, 2020
Revamp core components storybook doc(pt. 6)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Same as #246 but for
<SplitView>,<StatusIcon>,<Switch>,<SwitchIcon>,<Tag>.Side note:
autohideexample for<StatusIcon>, since there's no example before.Changes
/packages/storybook/examples: Update new storybook doc of<SplitView>,<StatusIcon>,<Switch>,<SwitchIcon>,<Tag>./packages/core: Update<Switch>,<SwitchIcon>,<StatusIcon>props doc for better props table description in storybook.Risk
None.
TODOs