Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix centered modal width #254

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Fix centered modal width #254

merged 1 commit into from
Feb 12, 2020

Conversation

chenesan
Copy link
Contributor

Purpose

Asana: https://app.asana.com/0/347798529122928/1161341114084393

This fix that when centering modal (<Modal centered />) the modal width is too wide. Also see #248 (comment)

Changes

  • Modal.scss. Define centered modal flex-basis and flex-grow.

Risk

None. Since on cloud2 there's no centered modal

UI screenshots

Before

螢幕快照 2020-02-11 下午4 28 27

After

螢幕快照 2020-02-11 下午4 27 48

TODOs

  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

@chenesan chenesan self-assigned this Feb 11, 2020
@chenesan chenesan added the bug label Feb 11, 2020
zhusee2
zhusee2 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix 👍

tz5514
tz5514 approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@tz5514 tz5514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenesan chenesan merged commit 5efb005 into project/update-core-components-storybook-doc Feb 12, 2020
@chenesan chenesan deleted the fix/should-not-widen-centered-modal-width branch February 12, 2020 08:40
@kyoyadmoon kyoyadmoon mentioned this pull request Feb 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tz5514 tz5514 tz5514 approved these changes

@zhusee2 zhusee2 zhusee2 approved these changes

@benny0642 benny0642 Awaiting requested review from benny0642

@kyoyadmoon kyoyadmoon Awaiting requested review from kyoyadmoon

Assignees

@chenesan chenesan

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenesan @zhusee2 @tz5514