Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deploy script to push tags #261

Merged
merged 3 commits into from
Mar 5, 2020
Merged

Fix deploy script to push tags #261

merged 3 commits into from
Mar 5, 2020

Conversation

zhusee2
Copy link
Contributor

@zhusee2 zhusee2 commented Mar 4, 2020

Changes

  • Fix deploy script to correctly push back converted tags, which will be used by lerna for determining version.
  • Always bump minor when releasing canary builds.

@zhusee2 zhusee2 added the bug label Mar 4, 2020
@zhusee2 zhusee2 added this to the v4 milestone Mar 4, 2020
@zhusee2 zhusee2 self-assigned this Mar 4, 2020
tz5514
tz5514 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@tz5514 tz5514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

強

@zhusee2 zhusee2 merged commit a47db98 into develop Mar 5, 2020
@zhusee2 zhusee2 deleted the fix/deploy_tags branch March 5, 2020 06:17
@chenesan chenesan mentioned this pull request Mar 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benny0642 benny0642 benny0642 approved these changes

@tz5514 tz5514 tz5514 approved these changes

@kyoyadmoon kyoyadmoon kyoyadmoon approved these changes

@chenesan chenesan Awaiting requested review from chenesan

Assignees

@zhusee2 zhusee2

Labels
bug
Projects
None yet
Milestone
v4
Development

Successfully merging this pull request may close these issues.
4 participants
@zhusee2 @kyoyadmoon @tz5514 @benny0642