Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Popup layout and props #271

Merged
merged 11 commits into from
Jun 22, 2020
Merged

Update Popup layout and props #271

merged 11 commits into from
Jun 22, 2020

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Jun 19, 2020 •
edited
Loading

Purpose

調整 <Popup> 樣式，並新增 <Popup> 預設 layout
新的基本用法可以在下面 preview 的 basic usage 看到
預設的 layout 應該已經能夠符合大多數情境
目前也支援原本 message 的 prop （雖然內部的結構變了，因為想要統一調整樣式）
如果對於 props 的調整有什麼想法，請告訴我 謝謝！

Preview: https://deploy-preview-271--gypcrete.netlify.app/?path=/story/ichef-gypcrete-popup--basic-usage

  • Add props for default Popup message layout

    • messageTitle
    • messageDesc
    • messageBottomArea

  • Add customMessageNode prop just in case that you want to render custom content.

  • message prop will be deprecated in the future

  • Update Popup styles

  • Fix typo variable name

  • Update Popup doc stories

image

Changes

  • Popup component and styles

Risk

  • Modified <Popup> internal DOM structure

@kyoyadmoon
Update Popup layout and props
64407ac 
Fix typo variable name
Update Popup doc stories
@kyoyadmoon kyoyadmoon closed this Jun 19, 2020
@kyoyadmoon kyoyadmoon reopened this Jun 19, 2020
@kyoyadmoon kyoyadmoon changed the base branch from develop to master June 19, 2020 14:45
@kyoyadmoon kyoyadmoon changed the base branch from master to develop June 19, 2020 14:45
chenesan
chenesan approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@chenesan chenesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netlify 讚讚

packages/core/src/Popup.js Outdated Show resolved Hide resolved
packages/core/src/styles/Popup.scss Outdated Show resolved Hide resolved
packages/core/src/Popup.js Show resolved Hide resolved
zhusee2
zhusee2 reviewed Jun 22, 2020
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Popup> 的測試看起來沒有測到新引入的 props

packages/core/src/Popup.js Outdated Show resolved Hide resolved
packages/core/src/styles/Popup.scss Outdated Show resolved Hide resolved
@kyoyadmoon kyoyadmoon requested a review from zhusee2 June 22, 2020 08:32
zhusee2
zhusee2 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice update 🚀

tz5514
tz5514 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@tz5514 tz5514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
記得把 JSX 縮排改回來

packages/core/src/Popup.js Outdated Show resolved Hide resolved
@kyoyadmoon kyoyadmoon merged commit dc7c68d into develop Jun 22, 2020
@kyoyadmoon kyoyadmoon deleted the feature/update-popup-ui branch June 22, 2020 09:54
@chenesan chenesan mentioned this pull request Jul 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenesan chenesan chenesan approved these changes

@benny0642 benny0642 benny0642 approved these changes

@tz5514 tz5514 tz5514 approved these changes

@zhusee2 zhusee2 zhusee2 approved these changes

Assignees

@kyoyadmoon kyoyadmoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kyoyadmoon @zhusee2 @tz5514 @chenesan @benny0642