Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add muted prop on rowComp() #278

Merged
merged 3 commits into from
Jul 17, 2020
Merged

Add muted prop on rowComp() #278

merged 3 commits into from
Jul 17, 2020

Conversation

chenesan
Copy link
Contributor

Purpose

Asana: https://app.asana.com/0/347798529122928/1179698171481649

下列的 component 會新增 muted prop，muted 為 true 時，會有 disabled 的樣式，但 click 時仍會觸發事件。

  • <Button>
  • <Checkbox>
  • <SearchInput>
  • <Switch>
  • <TextInput>
  • <TextLabel>
  • <ListRow>

實作上就是讓 rowComp() mixin 可以吃 muted，新增 .gyp-state-muted 的樣式，參照 .gyp-state-disabled 但拿掉 pointer-events: none 的限制。

Changes

Risk

Usually none, if you have any please write it here.

TODOs

  • Describe what should be done outside of this PR
  • Maybe in other PRs or some manual actions.

@chenesan chenesan force-pushed the feature/add-muted-prop-on-rowComp branch from a3eb829 to 041fe26 Compare July 13, 2020 09:47
@chenesan chenesan marked this pull request as ready for review July 13, 2020 09:47
@chenesan chenesan self-assigned this Jul 15, 2020
zhusee2
zhusee2 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@zhusee2 zhusee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benny0642
benny0642 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@benny0642 benny0642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenesan chenesan merged commit f6b9b64 into develop Jul 17, 2020
@chenesan chenesan deleted the feature/add-muted-prop-on-rowComp branch July 17, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benny0642 benny0642 benny0642 approved these changes

@tz5514 tz5514 tz5514 approved these changes

@zhusee2 zhusee2 zhusee2 approved these changes

@kyoyadmoon kyoyadmoon Awaiting requested review from kyoyadmoon

Assignees

@chenesan chenesan

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenesan @zhusee2 @tz5514 @benny0642