[Chore] auto generate icon index.js #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benny0642,
kyoyadmoon,
tz5514 and
zhusee2
benny0642
reviewed
Aug 4, 2020
| */ | ||
| function indexTemplate(filePaths) { | ||
| const importStatements = filePaths.map((filePath) => { | ||
| const exportName = path.basename(filePath, path.extname(filePath)); |
There was a problem hiding this comment.
(optional)exportName 叫 fileName 會不會比較直覺一點？
阿阿，但是它官方是寫 exportName，就看乙山大大惹，我只是看 path.basename(filePath, path.extname(filePath)) 截出來的是 fileName而已，不然我還自己開 node 試了一下這個邏輯。
There was a problem hiding this comment.
fileName 可啊，按我們的規範 component 名稱和檔名本來就應該一樣
benny0642
reviewed
Aug 4, 2020
Comment on lines
3
to
20
| function isUpperCase(char) { | ||
| return char.toUpperCase() === char; | ||
| } | ||
|
|
||
| function upperCamelCaseToKebabCase(inputString) { | ||
| let result = ''; | ||
| inputString.split('').forEach((char, i) => { | ||
| if (isUpperCase(char)) { | ||
| if (i !== 0) { | ||
| result += '-'; | ||
| } | ||
| result += char.toLowerCase(); | ||
| } else { | ||
| result += char; | ||
| } | ||
| }); | ||
| return result; | ||
| } |
There was a problem hiding this comment.
我猜應該有套件在做類似的事情，maybe https://github.com/blakeembrey/change-case?
There was a problem hiding this comment.
是有啦，可是想說這可以自己寫就處理掉，比較不會莫名引入有問題的 package
zhusee2
approved these changes
Aug 4, 2020
benny0642
approved these changes
Aug 4, 2020
kyoyadmoon
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
接著 #280，
src/icons/svg，自動產 index.js (用 svgr 的 custom index template)。產出來的 index.js 會放在src/icons/components裡面。configs/fontello.config.json，將引用它的 storybook 改成引用 icon components index.js。會導致 storybook 面 basic usage 的順序有點小差異(改成由 a-z)，但應該還好。至此，加入新 icon 的流程變成：
packages/core/src/icons/svg。yarn generate-icon-components。(這會吃下整個src/icons/svg資料夾，吐出 components 和 index.js 到src/icons/components。)Changes
Risk
應該沒有。
TODOs