New icons: plus-one and minus-one #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benny0642,
chenesan,
kyoyadmoon,
leannechen,
tz5514 and
zhusee2
|
看起來顏色好像怪怪的 (? |
kyoyadmoon
reviewed
Oct 12, 2020
| return ( | ||
| <svg width="1em" height="1em" viewBox="0 0 30 30" fill="none" {...props}> | ||
| <circle cx={15} cy={15} r={14.5} fill="#fff" stroke="#B0B0B0" /> | ||
| <path fill="#717171" d="M10 14h11v2H10z" /> |
There was a problem hiding this comment.
這裡是不是要改成
fill="currentColor"
There was a problem hiding this comment.
@kyoyadmoon 有沒有想把 Icon story 的 background 改成有顏色的底！
There was a problem hiding this comment.
這件事印象中之前 @chenesan 在改的時候好像有討論過
忘記後來為什麼沒做了
kyoyadmoon
reviewed
Oct 12, 2020
| export default function SvgMinusOne(props) { | ||
| return ( | ||
| <svg width="1em" height="1em" viewBox="0 0 30 30" fill="none" {...props}> | ||
| <circle cx={15} cy={15} r={14.5} fill="#fff" stroke="#B0B0B0" /> |
There was a problem hiding this comment.
這裡要把 fill 拿掉，不然如果背景是其他顏色，就會像下面的圖 😂
circle stroke 的顏色可以找設計確認一下是不是固定的
Suggested change
| <circle cx={15} cy={15} r={14.5} fill="#fff" stroke="#B0B0B0" /> | |
| <circle cx={15} cy={15} r={14.5} fill="transparent" stroke="#B0B0B0" /> |
a26620236
force-pushed
the
feature/add-icon-plus-one-and-minus-one
branch
from
2d0b799 to
7fe2f01
Compare
benny0642
reviewed
Oct 13, 2020
| export default function SvgMinusOne(props) { | ||
| return ( | ||
| <svg width="1em" height="1em" viewBox="0 0 30 30" fill="none" {...props}> | ||
| <circle cx={15} cy={15} r={14.5} fill="transparent" stroke="#B0B0B0" /> |
There was a problem hiding this comment.
好奇，如果變色的話， circle 的 stroke 要跟著變嗎？
譬如說，在 error status 的情況下，circle stroke 依然維持 #B0B0B0 還是 red?
There was a problem hiding this comment.
最後設計師決定不填滿了，只有改變 stroke 。
leannechen
approved these changes
Oct 13, 2020
a26620236
commented
Oct 16, 2020
a26620236
requested review from
zhusee2,
leannechen,
benny0642 and
kyoyadmoon
a26620236
force-pushed
the
feature/add-icon-plus-one-and-minus-one
branch
from
734ab0f to
64ce3a8
Compare
chenesan
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
新增兩個改變數量的按鈕，plus-one/minus-one，用來改變交易明細列印設定裡面的預設張數
plus-one: