Fix popover placement when there is no enough space on top or bottom of content #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenesan
changed the title
chenesan
requested review from
a26620236,
kyoyadmoon,
leannechen,
tz5514,
zhusee2 and
benny0642
chenesan
commented
Dec 9, 2020
packages/core/src/Popover.js
Outdated
| <div className={BEM.container}> | ||
| <div | ||
| className={BEM.container} | ||
| style={{ maxHeight: remainingSpace ? remainingSpace - popoverPadding : undefined }} |
There was a problem hiding this comment.
remainingSpace 是指扣掉箭頭後剩餘的高度，因此還要再扣掉 Popover 自身的 padding
chenesan
commented
Dec 9, 2020
Comment on lines
-63
to
+80
| positionTop = anchorOffsetTop - selfHeight; | ||
| // Make sure user can see whole wrapped component when placement is TOP. | ||
| positionTop = Math.max(anchorOffsetTop - selfHeight, 0); |
There was a problem hiding this comment.
確保當 placement 為 TOP 時，Popover 最高只會被擺到畫面上緣。如果是負的有可能會看不到 Popover 上半部。
kyoyadmoon
reviewed
Dec 9, 2020
packages/core/src/Popover.js
Outdated
| @@ -45,6 +46,8 @@ function Popover({ | |||
| onClick(event); | |||
| }; | |||
|
|
|||
| const popoverPadding = 24; | |||
There was a problem hiding this comment.
覺得 popoverPadding 可以移到 function 外宣告
然後直接在這裡算 maxHeight
const maxHeight = remainingSpace ? remainingSpace - popoverPadding : undefined;
zhusee2
approved these changes
Dec 11, 2020
Comment on lines
+34
to
+40
| expected | defaultVal | situation | anchorTop | anchorHeight | selfHeight | remainingSpace | ||
| ${TOP} | ${TOP} | ${'enough'} | ${120} | ${30} | ${100} | ${120} | ||
| ${BOTTOM} | ${TOP} | ${'not enough for top'} | ${90} | ${30} | ${100} | ${648} | ||
| ${TOP} | ${BOTTOM} | ${'not enough for bottom'} | ${600} | ${100} | ${100} | ${600} | ||
| ${BOTTOM} | ${BOTTOM} | ${'enough'} | ${300} | ${100} | ${100} | ${368} | ||
| ${BOTTOM} | ${BOTTOM} | ${'not enough for both, but bottom is larger'} | ${300} | ${100} | ${400} | ${368} | ||
| ${TOP} | ${BOTTOM} | ${'not enough for both, but top is larger'} | ${450} | ${100} | ${500} | ${450} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
修正當 placement 設定為向下 (
bottom) 的 popover 下方空間不足時往上長，結果導致看不到 popover 上半部的問題。這是因為現在
anchored的邏輯，在原本的 placement 向下且空間不足時，就會往上。因此當 popover 的內容沒有出現捲軸(不超過max-height)，但又比上方空間長時，popover 上面的東西就點不到。解法：當 popover 的 placement 設定為向下，且下方和上方的空間都不足時，還是向下長。缺點是有機會破圖，但相對不能按應該還是好些。根據後續的討論，改成在上下都不夠顯示 popover 時，用空間較足夠的那邊作為 placement。並且計算剩餘空間給下面的
<Popover>作為max-height來確保不會高到破版。Changes
Risk
會影響到
<Tooltip>和<Popover>在 placement 設為 bottom 且上下空間都不夠時的行為，其餘不影響。TODOs