add new icon #316
Merged
add new icon #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benny0642,
brianwu291,
chenesan,
kyoyadmoon,
leannechen,
sharonshenzizi,
tz5514,
YuCJ and
zhusee2
chenesan
approved these changes
Apr 23, 2021
YuCJ
approved these changes
Apr 23, 2021
kyoyadmoon
reviewed
Apr 23, 2021
| > | ||
| <path | ||
| d="M.477 9.148h1.181a.443.443 0 00.443-.444 6.579 6.579 0 011.368-4.036A6.6 6.6 0 018.75 2.066c1.469 0 2.862.472 4.029 1.365.386.296.734.627 1.04.99l-2.18-.386a.443.443 0 00-.513.36l-.205 1.162c-.043.24.118.47.359.513l5.232.924a.441.441 0 00.513-.36l.924-5.232a.443.443 0 00-.36-.513L16.429.684a.442.442 0 00-.513.359l-.389 2.202a8.747 8.747 0 00-1.49-1.455A8.621 8.621 0 008.752 0a8.653 8.653 0 00-6.924 3.412A8.629 8.629 0 00.034 8.706a.443.443 0 00.443.442zM17.836 8.982a.443.443 0 00-.313-.13h-1.18a.443.443 0 00-.443.444 6.58 6.58 0 01-1.369 4.036 6.6 6.6 0 01-5.282 2.602A6.574 6.574 0 015.22 14.57a6.68 6.68 0 01-1.04-.989l2.18.385a.442.442 0 00.513-.36l.205-1.162a.443.443 0 00-.359-.513l-5.232-.924a.443.443 0 00-.513.36L.05 16.597c-.042.24.119.47.36.513l1.162.205a.443.443 0 00.513-.36l.389-2.201c.436.54.937 1.031 1.49 1.455A8.62 8.62 0 009.248 18a8.653 8.653 0 006.924-3.412 8.63 8.63 0 001.794-5.294.443.443 0 00-.13-.312z" | ||
| fill="#231F20" |
There was a problem hiding this comment.
這個 fill 是不是應該換成 currentColor
zhusee2
approved these changes
Apr 23, 2021
kyoyadmoon
reviewed
Apr 23, 2021
| <svg | ||
| width="1em" | ||
| height="1em" | ||
| viewBox="0 0 18 18" |
There was a problem hiding this comment.
看了一下 preview ，好像長的稍微大一點
之前的 viewBox 好像都是 32 要不要再確認一下尺寸？
kyoyadmoon
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
記得要用 conventional commit
https://www.conventionalcommits.org/en/v1.0.0/
benny0642
approved these changes
Apr 26, 2021
a26620236
force-pushed
the
feature/add_new_icon
branch
from
2616fe5 to
64b3d82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add new icon
Changes
Risk
Usually none, if you have any please write it here.
TODOs