[RadioSelectList] 實作 RadioSelectList, RadioSelectOption #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benny0642
commented
May 3, 2022
Comment on lines
+23
to
+27
| // default props for RadioSelectList | ||
| multiple={false} | ||
| showCheckAll={false} | ||
| checkAllLabel={null} | ||
| minCheck={undefined} |
There was a problem hiding this comment.
透過這些 props 寫死 RadioSelectList 是一個單選的 SelectList
Base automatically changed from
feature/radio-component
to
project/radio_select_list
May 3, 2022 13:48
leannechen
reviewed
May 4, 2022
| onChange: () => {}, | ||
| }; | ||
|
|
||
| RadioSelectOption.typeSymbol = TYPE_SYMBOL; |
There was a problem hiding this comment.
(optional) 也許可以補個需要 typeSymbol 的原因，讓讀者知道可去看 SelectOption comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Risk
Usually none, if you have any please write it here.
TODOs