Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/5.0.0 #349

Merged
merged 81 commits into from
May 13, 2022
Merged
Changes from 1 commit
Commits
Show all changes
81 commits
Select commit Hold shift + click to select a range
39aa011
feat: add `add-location` icon
leannechen Mar 22, 2022
87ba9ce
feat: remove fixed `fill` color
leannechen Mar 22, 2022
b2e51ca
feat: change `fill` value to currentColor
leannechen Mar 22, 2022
69fa2b6
Merge pull request #328 from iCHEF/feature/add_location_icon
leannechen Mar 22, 2022
1587e69
Merge pull request #331 from iCHEF/backport/4.4.0
a26620236 Mar 22, 2022
673ad51
fix: should not asideControlClickableOnDisabled if not disabled
chenesan Mar 30, 2022
eaf4f84
docs: update CHANGELOG.md
chenesan Mar 30, 2022
ea55cf7
Merge pull request #332 from iCHEF/bugfix/should_not_apply_aside_cont…
chenesan Mar 31, 2022
d7a5cc3
feat: add Location icon
leannechen Apr 7, 2022
2df6473
doc: update Changelog
leannechen Apr 7, 2022
348f117
Merge pull request #333 from iCHEF/feature/location-icon
leannechen Apr 8, 2022
86aee36
feat: specify node maximum version in package.json
leannechen Apr 8, 2022
4c0a1b9
feat: add .nvmrc for node version
leannechen Apr 8, 2022
ad2600b
feat: change Location icon
leannechen Apr 8, 2022
4bb5200
Merge pull request #334 from iCHEF/chore/specify-node-version
leannechen Apr 11, 2022
eff64ae
Merge pull request #335 from iCHEF/feature/change-location-icon
leannechen Apr 11, 2022
8ad1d7b
feat: change AddLocation icon
leannechen Apr 22, 2022
488503d
fix: lint issue
leannechen Apr 22, 2022
5fee666
Merge pull request #336 from iCHEF/feature/change-add-location-icon
leannechen Apr 22, 2022
369a6b3
feat(CheckboxEmpty): rename radio-empty with checkbox-empty
benny0642 Apr 29, 2022
33cf1da
feat(CheckboxHalf): rename to CheckboxHalf
benny0642 Apr 29, 2022
0883c8d
feat(CheckboxSelected): rename to CheckboxSelected
benny0642 Apr 29, 2022
ad75ef6
feat: add radio-empty.svg and radio-selected.svg
benny0642 May 3, 2022
cdfb6d4
feat: add SvgRadioEmpty and SvgRadioSelected
benny0642 May 3, 2022
5f86132
Merge pull request #337 from iCHEF/feature/rename_checkbox_icon
benny0642 May 3, 2022
df4e347
feat: implement Radio component
benny0642 May 3, 2022
d54c000
fix: clean code
benny0642 May 3, 2022
d595eaf
feat: implement RadioSelectList and RadioSelectOption
benny0642 May 3, 2022
984dedc
feat: add props for RadioSelectList
benny0642 May 3, 2022
53f3719
fix: fix props name
benny0642 May 3, 2022
f7a5b09
docs: update CHANGELOG
benny0642 May 3, 2022
15597c2
Merge pull request #338 from iCHEF/feature/radio-svg-component
benny0642 May 3, 2022
830c305
fix: fix code review
benny0642 May 3, 2022
ba3c3c4
test(parseSelectOptions): add unit test for RadioSelectOption
benny0642 May 3, 2022
8fd67ce
Merge pull request #339 from iCHEF/feature/radio-component
benny0642 May 3, 2022
5f56f15
feat: add ci workflow with codecov
kyoyadmoon May 4, 2022
1262b03
fix: lint error
kyoyadmoon May 4, 2022
94dbe0d
fix: remove build job
kyoyadmoon May 4, 2022
af43a4e
chore: change stylelint config indentation to 2
kyoyadmoon May 4, 2022
176bc6f
fix: fix scss file indentation
kyoyadmoon May 4, 2022
c2e19db
chore: remove unused action input
kyoyadmoon May 4, 2022
ca5074d
docs: update comment for typeSymbol
benny0642 May 5, 2022
ff67967
Merge pull request #340 from iCHEF/feature/radio-select-list
benny0642 May 5, 2022
62b44e8
Merge pull request #343 from iCHEF/project/radio_select_list
benny0642 May 5, 2022
825d0b1
feat: export RadioSelectList and RadioSelectOption
benny0642 May 5, 2022
fb3de7b
test(Radio): add Radio unit tests
benny0642 May 5, 2022
7edc1d5
Merge pull request #344 from iCHEF/feature/export_radio_select_list
benny0642 May 5, 2022
26ac5bb
test(RadioSelectList): add unit tests
benny0642 May 5, 2022
000b7fb
test(RadioSelectOption): add unit tests
benny0642 May 5, 2022
4400882
chore(package.json): add jest:watch script
benny0642 May 5, 2022
3ff5ed1
feat: use ichef npm-install-with-cache-action to install packages
kyoyadmoon May 5, 2022
90f859f
chore: remove unused local actions
kyoyadmoon May 6, 2022
192aad5
Merge branch 'develop' of https://github.com/iCHEF/gypcrete into feat…
kyoyadmoon May 6, 2022
e1b1bb1
fix: lint error
kyoyadmoon May 6, 2022
9cf2722
fix: linter errors in Radio.scss
kyoyadmoon May 6, 2022
ba0884c
Merge pull request #341 from iCHEF/feat/add-ci-workflow
kyoyadmoon May 6, 2022
e1da772
Merge branch 'feat/add-ci-workflow' of https://github.com/iCHEF/gypcr…
kyoyadmoon May 6, 2022
ff68819
fix: scss stylelint errors
kyoyadmoon May 6, 2022
e79cf6c
Merge pull request #342 from iCHEF/chore/change-stylelint-indent
kyoyadmoon May 6, 2022
8244088
Merge pull request #345 from iCHEF/test/radio_select_list
benny0642 May 6, 2022
7b95c83
fix(package.json): fix generate-icon-components script
benny0642 May 6, 2022
6db6451
docs: update CHANGELOG
benny0642 May 6, 2022
fa17c3d
feat: add canary release workflow
a26620236 May 8, 2022
57047ca
chore: fix typo
a26620236 May 8, 2022
6620403
feat: add release workflow
a26620236 May 8, 2022
00fba6d
feat: update release workflow
a26620236 May 9, 2022
40cfe3a
feat: update release workflow with `iCHEF/npm-install-with-cache-acti…
a26620236 May 9, 2022
c305dc3
Merge branch 'develop' into feature/add_release_workflow
a26620236 May 9, 2022
964933d
Merge branch 'develop' into feature/add_canary_workflow
a26620236 May 9, 2022
2da930d
fix: CI never stop running caused by watch mode
a26620236 May 9, 2022
0deacac
chore: update package name used in canary release workflow
a26620236 May 9, 2022
fd37cc5
chore: update package name used in canary release workflow
a26620236 May 9, 2022
579aaf6
Merge pull request #346 from iCHEF/feature/add_canary_workflow
a26620236 May 9, 2022
e8e39bb
Merge branch 'develop' into feature/add_release_workflow
a26620236 May 9, 2022
08086fa
chore: update package name used in canary release workflow and script…
a26620236 May 9, 2022
ad22c1f
feat: add "conventional-changelog-cli to package.json
a26620236 May 9, 2022
5b32861
Merge pull request #347 from iCHEF/fix/generate-icon-components-script
benny0642 May 11, 2022
674be48
Merge pull request #348 from iCHEF/feature/add_release_workflow
a26620236 May 12, 2022
c4a99b1
feat: deleted unused travis cd
a26620236 May 13, 2022
c06773e
feat: deleted unused deploy.sh
a26620236 May 13, 2022
b3ae98d
Merge pull request #350 from iCHEF/feature/delete_unused_travis
a26620236 May 13, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: add props for RadioSelectList
benny0642 committed May 3, 2022
commit 984dedccdd7a0655de582ccde184000b5c94fd02
15 changes: 12 additions & 3 deletions packages/form/src/RadioSelectList.js
Original file line number Diff line number Diff line change
@@ -4,18 +4,27 @@ import PropTypes from 'prop-types';
import { valueType } from './RadioSelectOption';
import SelectList from './SelectList';


export default function RadioSelectList({
// TODO: omit
value,
defaultValue,
onChange,
title,
desc,
...otherProps
}) {
return (
<SelectList
value={value}
defaultValue={defaultValue}
onChange={onChange}
title={title}
desc={desc}
{...otherProps}
// default props for RadioSelectList
multiple={false}
showCheckAll={false}
checkAllLabel={null}
minCheck={0}
minCheck={undefined}
/>
);
}