Refactor editable components #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjies
approved these changes
Jul 4, 2017
…s 'editEnd' event
…use-cases only apply here
…touchable on loading
zhusee2
force-pushed
the
feature/zhusee_refactor_editable
branch
from
cfaf2d6 to
cc0ed06
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Split out
<EditableBasicRow>which handles the input from<EditableText>, so eachEditable*components can be more focused.Implement
<EditableBasicRow>. It renders an<input>inside along with the basic label showing what you read on the input.<EditableText>is simplified to only passes to/removes the status-related props from<EditableBasicRow>.<TextInput>is thus simplified to just pass props to<EditableText>.<EditableTextLabel>is now the only component that's responsible for managing input value changes. It discards input onEsckey, and report the input value onEnterkey and input blurs.Editable*components.