Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure the correct behavior of non-required field #28

Merged
merged 2 commits into from
Jun 25, 2018
Merged

ensure the correct behavior of non-required field #28

merged 2 commits into from
Jun 25, 2018

Conversation

timtan
Copy link
Contributor

@timtan timtan commented Jun 25, 2018

Purpose

https://github.com/iCHEF/iCHEF-Cloud2.0/issues/2053

Changes

  • remove required in schema use in inventory milestone one
  • make date time filter behavior correct. it will return None if queryfilter value is missing

@timtan timtan merged commit 1686263 into master Jun 25, 2018
@timtan timtan deleted the feature/date-onnly-queryfilter branch June 25, 2018 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidleeplaysmart davidleeplaysmart davidleeplaysmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timtan @davidleeplaysmart