Skip to content

Conversation

akugone
Copy link
Collaborator

@akugone akugone commented Aug 4, 2025

No description provided.

Copy link

vercel bot commented Aug 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 5, 2025 7:45am

@Le-Caignec Le-Caignec changed the base branch from main to feature/protect-and-manage-data August 4, 2025 15:50
@Le-Caignec Le-Caignec requested a review from Copilot August 4, 2025 16:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the documentation for iExec's Data Protector feature by improving visual design and content clarity across multiple documentation files. The changes focus on making the documentation more user-friendly and visually appealing.

Key Changes:

  • Updated the main Protected Data overview with enhanced styling and expanded content
  • Added visual improvements with styled cards, gradients, and better formatting
  • Clarified explanations and added new use cases for protected data

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/manage-data/what-is-protected-data.md Complete redesign with enhanced visual styling, expanded use cases, and improved content structure
src/manage-data/guides/handle-schemas-dataset-types.md Added clarity points about schemas with improved formatting
src/manage-data/guides/create-and-share-access.md Simplified and clarified explanations for data protection and access control
src/manage-data/dataProtector/types.md Enhanced type documentation with improved formatting and visual styling

Copy link
Collaborator

@Le-Caignec Le-Caignec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to fix 🙏🏼
Good team work 🤝

<div class="flex items-center gap-3">
<span>•</span>
<div>
<strong>Encrypted processing:</strong> Data is encrypted during computation
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we can say that TEE processing is like encrypted processing. For me, it’s more like a black box where all the data is in cleartext and unencrypted — just not visible from the outside.

<div class="flex items-start gap-3">
<span class="text-xl">📚</span>
<div>
<strong>Learn More:</strong> <a href="/manage-data/guides" class="text-fuchsia-700 hover:text-fuchsia-600">Complete DataProtector Documentation</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<strong>Learn More:</strong> <a href="/manage-data/guides" class="text-fuchsia-700 hover:text-fuchsia-600">Complete DataProtector Documentation</a>
<strong>Learn More:</strong> <a href="/manage-data/guides/create-and-share-access" class="text-fuchsia-700 hover:text-fuchsia-600">Complete DataProtector Documentation</a>

/manage-data/guides is a dead link. Are you agree to redirect builders to the first guide ?

<div class="flex items-start gap-3">
<span class="text-xl">🚀</span>
<div>
<strong>Getting Started:</strong> <a href="/manage-data/dataProtector/getting-started" class="text-fuchsia-700 hover:text-fuchsia-600">DataProtector Quick Start Guide</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be the first next step could be the guide and after the getting started of the SDK ?

Le-Caignec and others added 2 commits August 4, 2025 18:27
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
akugone and others added 3 commits August 5, 2025 09:31
Co-authored-by: Robin Le Caignec <72495599+Le-Caignec@users.noreply.github.com>
@akugone akugone merged commit fd963a6 into feature/protect-and-manage-data Aug 5, 2025
2 of 3 checks passed
@akugone akugone deleted the feature/protect-and-manage-data-martin branch August 5, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants