Manage upload to ipfs #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
February 27, 2019 16:39
jeremyjams
requested changes
Mar 11, 2019
| @@ -346,10 +360,24 @@ private boolean isTaskStatusFailOnChain(String chainTaskId, String walletAddress | |||
| } | |||
| } | |||
|
|
|||
| boolean isPublicResult(String chainTaskId, Integer chainId) { | |||
There was a problem hiding this comment.
Can we move isPublicResult to common? (We're gonna need it for the seperate Result Repo)
| boolean isPublicResult(String chainTaskId) { | ||
| return isPublicResult(chainTaskId, 0); | ||
| } | ||
|
|
||
| boolean isPublicResult(String chainTaskId, Integer chainId) { |
| return Optional.empty(); | ||
| } | ||
|
|
||
| public boolean doesContentExists(String ipfsHash) { |
| @@ -170,6 +169,16 @@ private int getNbReplicatesWithGivenStatusJustBeforeWorkerLost(String chainTaskI | |||
| return Optional.empty(); | |||
| } | |||
|
|
|||
| public Optional<Replicate> getReplicateWithResultUploadedStatus(String chainTaskId) { | |||
There was a problem hiding this comment.
It seems we have an issue when worker is lost after UPLOADED
There was a problem hiding this comment.
There was a problem hiding this comment.
great catch, thanks! I've modified the code.
jeremyjams
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to publish the results depending on the beneficiary of the task:
Some refactoring will be needed to split the replicate update status into several entrypoints instead of a single one at the moment.