Refactor Replicate#getLastRelevantStatus to remove the Optional return type
#524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbern0rd
reviewed
Oct 4, 2022
|
|
||
| if (lastRelevantStatus.get().equals(ReplicateStatus.CONTRIBUTED)) { | ||
| ReplicateStatus lastRelevantStatus = replicate.getLastRelevantStatus(); | ||
| if (lastRelevantStatus.equals(ReplicateStatus.CONTRIBUTED)) { |
There was a problem hiding this comment.
I tend to prefer the inverted syntax for NPE protection
Suggested change
| if (lastRelevantStatus.equals(ReplicateStatus.CONTRIBUTED)) { | |
| if (ReplicateStatus.CONTRIBUTED.equals(lastRelevantStatus)) { |
There was a problem hiding this comment.
Using == is a bit better for enums. Please see 566e532 :)
jbern0rd
reviewed
Oct 4, 2022
src/main/java/com/iexec/core/replicate/ReplicateSupplyService.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
mcornaton
deleted the
bugfix/remove-optional-from-getLastRelevantStatus
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR goal: fix SonarCloud detected bugs on
Replicate#getLastRelevantStatus