Bugfix/task added twice #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbern0rd
approved these changes
Jan 30, 2023
jbern0rd
approved these changes
Jan 30, 2023
jeremyjams
reviewed
Jan 30, 2023
| execution.get(1, TimeUnit.MINUTES); | ||
| } catch (ExecutionException e) { | ||
| if (e.getCause() instanceof DuplicateKeyException) { | ||
| fail("Task has been added twice. Should not happen!"); |
There was a problem hiding this comment.
I'm not sure this can happen 🤔
There was a problem hiding this comment.
You're right. This should not happen anymore. However, I'd like to keep it there. This would ensure that, if we ever refactor TaskService#addTask, we still handle such a case.
There was a problem hiding this comment.
I agree. Shouldn't we try to check the addTask method returns the correct value as well ?
There was a problem hiding this comment.
Please see this other PR: #547
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.