iExecBlockchainComputing · thewhitewizard · May 9, 2023 · May 9, 2023
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to this project will be documented in this file.
 ### New Features
 - Add ContributeAndFinalize to `ReplicateWorkflow`. (#574)
 - Add check for ContributeAndFinalize in `ReplicatesService`. (#576)
+- Add `running2Finalized2Completed` in `TaskUpdateManager`. (#577)
 ### Bug Fixes
 - Prevent race condition on replicate update. (#568)
 ### Quality

diff --git a/src/main/java/com/iexec/core/task/update/TaskUpdateManager.java b/src/main/java/com/iexec/core/task/update/TaskUpdateManager.java
@@ -46,7 +46,7 @@
 
 @Service
 @Slf4j
-class TaskUpdateManager  {
+class TaskUpdateManager {
     private final TaskService taskService;
     private final IexecHubService iexecHubService;
     private final ReplicatesService replicatesService;
@@ -82,7 +82,7 @@ void updateTask(String chainTaskId) {
 
         boolean isFinalDeadlinePossible =
                 !TaskStatus.getStatusesWhereFinalDeadlineIsImpossible().contains(currentStatus);
-        if (isFinalDeadlinePossible && new Date().after(task.getFinalDeadline())){
+        if (isFinalDeadlinePossible && new Date().after(task.getFinalDeadline())) {
             updateTaskStatusAndSave(task, FINAL_DEADLINE_REACHED);
             // Eventually should fire a "final deadline reached" notification to worker,
             // but here let's just trigger an toFailed(task) leading to a failed status
@@ -175,7 +175,7 @@ Task updateTaskStatusAndSave(Task task, TaskStatus newStatus, ChainReceipt chain
             return savedTask.get();
         } else {
             log.warn("UpdateTaskStatus failed. Chain Task is probably unknown." +
-                    " [chainTaskId:{}, currentStatus:{}, wishedStatus:{}]",
+                            " [chainTaskId:{}, currentStatus:{}, wishedStatus:{}]",
                     task.getChainTaskId(), currentStatus, newStatus);
             return null;
         }
@@ -204,7 +204,7 @@ void received2Initializing(Task task) {
 
         if (task.isTeeTask()) {
             Optional<String> smsUrl = smsService.getVerifiedSmsUrl(task.getChainTaskId(), task.getTag());
-            if(smsUrl.isEmpty()){
+            if (smsUrl.isEmpty()) {
                 log.error("Couldn't get verified SMS url [chainTaskId: {}]", task.getChainTaskId());
                 updateTaskStatusAndSave(task, INITIALIZE_FAILED);
                 updateTaskStatusAndSave(task, FAILED);
@@ -241,7 +241,7 @@ void received2Initializing(Task task) {
     }
 
     void initializing2Initialized(Task task) {
-        if (!INITIALIZING.equals(task.getCurrentStatus())){
+        if (!INITIALIZING.equals(task.getCurrentStatus())) {
             return;
         }
         // TODO: the block where initialization happened can be found
@@ -262,7 +262,7 @@ void initializing2Initialized(Task task) {
                     updateTaskStatusAndSave(task, INITIALIZE_FAILED);
                     updateTaskStatusAndSave(task, FAILED);
                 }, () -> log.error("Unable to check initialization on blockchain " +
-                        "(likely too long), should use a detector [chainTaskId:{}]",
+                                "(likely too long), should use a detector [chainTaskId:{}]",
                         task.getChainTaskId()));
     }
 
@@ -326,6 +326,46 @@ void running2ConsensusReached(Task task) {
         }
     }
 
+    void running2Finalized2Completed(Task task) {
+        boolean isTaskInRunningStatus = task.getCurrentStatus().equals(RUNNING);
+        final String chainTaskId = task.getChainTaskId();
+        final Optional<ReplicatesList> oReplicatesList = replicatesService.getReplicatesList(chainTaskId);
+
+        if (!isTaskInRunningStatus) {
+            log.error("Can't transition task to `Finalized` or `Completed` when task is not `Running` " +
+                    " [chainTaskId:{}]", chainTaskId);
+            return;
+        }
+
+        if (oReplicatesList.isEmpty()) {
+            log.error("Can't transition task to `Finalized` or `Completed` when no replicatesList exists" +
+                    " [chainTaskId:{}]", chainTaskId);
+            return;
+        }
+
+        if (!task.isTeeTask()) {
+            log.debug("Task not running in a TEE, flow running2Finalized2Completed is not possible"
+                    + " [chainTaskId:{}]", chainTaskId);
+            return;
+        }
+        final ReplicatesList replicates = oReplicatesList.get();
+        final int nbReplicatesWithContributeAndFinalizeStatus = replicates.getNbReplicatesWithCurrentStatus(ReplicateStatus.CONTRIBUTE_AND_FINALIZE_DONE);
+
+        if (nbReplicatesWithContributeAndFinalizeStatus == 0) {
+            log.debug("No replicate in ContributeAndFinalize status"
+                    + " [chainTaskId:{}]", chainTaskId);
+            return;
+        } else if (nbReplicatesWithContributeAndFinalizeStatus > 1) {
+            log.error("Too many replicates in ContributeAndFinalize status"
+                    + " [chainTaskId:{}, nbReplicates:{}]", chainTaskId, nbReplicatesWithContributeAndFinalizeStatus);
+            toFailed(task);
+            return;
+        }
+
+        updateTaskStatusAndSave(task, FINALIZED);
+        finalizedToCompleted(task);
+    }
+
     void initializedOrRunning2ContributionTimeout(Task task) {
         boolean isInitializedOrRunningTask = task.getCurrentStatus().equals(INITIALIZED) ||
                 task.getCurrentStatus().equals(RUNNING);

diff --git a/src/test/java/com/iexec/core/task/update/TaskUpdateManagerTest.java b/src/test/java/com/iexec/core/task/update/TaskUpdateManagerTest.java
@@ -682,6 +682,88 @@ void shouldUpdateFromInitializedOrRunning2ContributionTimeout() {
         assertThat(task.getLastButOneStatus()).isEqualTo(CONTRIBUTION_TIMEOUT);
     }
 
+    // Tests on running2Finalized2Completed transition
+
+    @Test
+    void shouldUpdateRunning2Finalized2Completed() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(RUNNING);
+        task.setTag(TeeUtils.TEE_SCONE_ONLY_TAG);
+
+        final ReplicatesList replicatesList = Mockito.spy(new ReplicatesList(CHAIN_TASK_ID));
+
+        when(replicatesService.getReplicatesList(CHAIN_TASK_ID)).thenReturn(Optional.of(replicatesList));
+        when(replicatesList.getNbReplicatesWithCurrentStatus(ReplicateStatus.CONTRIBUTE_AND_FINALIZE_DONE)).thenReturn(1);
+        when(taskService.updateTask(task)).thenReturn(Optional.of(task));
+        doNothing().when(applicationEventPublisher).publishEvent(any());
+
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getLastButOneStatus()).isEqualTo(FINALIZED);
+        assertThat(task.getCurrentStatus()).isEqualTo(COMPLETED);
+    }
+
+    @Test
+    void shouldNotUpdateRunning2Finalized2CompletedWhenTaskNotRunning() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(INITIALIZED);
+
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getCurrentStatus()).isEqualTo(INITIALIZED);
+    }
+
+    @Test
+    void shouldNotUpdateRunning2Finalized2CompletedWhenNoReplicates() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(RUNNING);
+
+        when(replicatesService.getReplicatesList(CHAIN_TASK_ID)).thenReturn(Optional.empty());
+
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getCurrentStatus()).isEqualTo(RUNNING);
+    }
+
+    @Test
+    void shouldNotUpdateRunning2Finalized2CompletedWhenTaskIsNotTee() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(RUNNING);
+        task.setTag(NO_TEE_TAG);
+        final ReplicatesList replicatesList = Mockito.spy(new ReplicatesList(CHAIN_TASK_ID));
+
+        when(replicatesService.getReplicatesList(CHAIN_TASK_ID)).thenReturn(Optional.of(replicatesList));
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getCurrentStatus()).isEqualTo(RUNNING);
+    }
+
+    @Test
+    void shouldNotUpdateRunning2Finalized2CompletedWhenNoReplicatesOnContributeAndFinalizeStatus() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(RUNNING);
+        task.setTag(TeeUtils.TEE_SCONE_ONLY_TAG);
+
+        final ReplicatesList replicatesList = Mockito.spy(new ReplicatesList(CHAIN_TASK_ID));
+
+        when(replicatesService.getReplicatesList(CHAIN_TASK_ID)).thenReturn(Optional.of(replicatesList));
+        when(replicatesList.getNbReplicatesWithCurrentStatus(ReplicateStatus.CONTRIBUTE_AND_FINALIZE_DONE)).thenReturn(0);
+
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getCurrentStatus()).isEqualTo(RUNNING);
+    }
+
+    @Test
+    void shouldNotUpdateRunning2Finalized2CompletedWhenMoreThanOneReplicatesOnContributeAndFinalizeStatus() {
+        Task task = getStubTask(maxExecutionTime);
+        task.changeStatus(RUNNING);
+        task.setTag(TeeUtils.TEE_SCONE_ONLY_TAG);
+
+        final ReplicatesList replicatesList = Mockito.spy(new ReplicatesList(CHAIN_TASK_ID));
+
+        when(replicatesService.getReplicatesList(CHAIN_TASK_ID)).thenReturn(Optional.of(replicatesList));
+        when(replicatesList.getNbReplicatesWithCurrentStatus(ReplicateStatus.CONTRIBUTE_AND_FINALIZE_DONE)).thenReturn(2);
+        doNothing().when(applicationEventPublisher).publishEvent(any());
+
+        taskUpdateManager.running2Finalized2Completed(task);
+        assertThat(task.getCurrentStatus()).isEqualTo(FAILED);
+    }
 
     // Tests on running2ConsensusReached transition