Use @DataMongoTest and @Testcontainers annotations in WorkerServiceTests
#665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbern0rd
changed the title
@DataMongoTest and @Testcontainers annotations in `WorkerSer…@DataMongoTest and @Testcontainers annotations in WorkerServiceTests
mcornaton
reviewed
Feb 20, 2024
| private MongoTemplate mongoTemplate; | ||
| @Mock | ||
| @SpyBean |
There was a problem hiding this comment.
Should we try and remove this @SpyBean annotation? It is used twice:
- On line 192, to assert that a
savehas been done. This could be replaced by checking the object can be retrieved from the repository; - On line 479, to mock a call. This could be replaced by inserting the object beforehand.
There was a problem hiding this comment.
Please see aeb00e1
| Assertions.assertThat(aliveWorkersGauge).isNotNull(); | ||
| Assertions.assertThat(aliveTotalCpuGauge).isNotNull(); | ||
| Assertions.assertThat(aliveAvailableCpuGauge).isNotNull(); | ||
| assertThat(aliveWorkersGauge).isNotNull(); |
There was a problem hiding this comment.
with the test modification, you didn't take the opportunity to use assertAll ?
There was a problem hiding this comment.
Please see aeb00e1
| Assertions.assertThat(aliveWorkersGauge.value()).isZero(); | ||
| Assertions.assertThat(aliveTotalCpuGauge.value()).isZero(); | ||
| Assertions.assertThat(aliveAvailableCpuGauge.value()).isZero(); | ||
| assertThat(aliveWorkersGauge).isNotNull(); |
There was a problem hiding this comment.
with the test modification, you didn't take the opportunity to use assertAll ?
There was a problem hiding this comment.
Please see aeb00e1
|
jbern0rd
deleted the
bugfix/use-testcontainers-in-worker-service-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.