Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement each task status transition in a single method #680

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Implement each task status transition in a single method #680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
33ea669
Implement each task status transition in a single method
jbern0rd Mar 18, 2024
f635843
Only check `ChainTask` against null after the task
jbern0rd Mar 18, 2024
0b5fd53
Fix
jbern0rd Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file.
- Prepare migration to `java.time` package by building `Date` objects from `Instant` objects. (#671)
- Add logs for better traceability. (#675)
- Remove code only used in tests from `TaskService` and `Task`. (#678 #679)
- Implement each task status transition in a single method. (#680)

## [[8.4.0]](https://github.com/iExecBlockchainComputing/iexec-core/releases/tag/v8.4.0) 2024-02-29

Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/iexec/core/chain/IexecHubService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,9 @@ Flowable<IexecHubContract.SchedulerNoticeEventResponse> getDealEventObservable(E
}

public boolean hasEnoughGas() {
return hasEnoughGas(credentialsService.getCredentials().getAddress());
final boolean hasEnoughGas = hasEnoughGas(credentialsService.getCredentials().getAddress());
log.debug("Gas status [hasEnoughGas:{}]", hasEnoughGas);
return hasEnoughGas;
}

private ChainReceipt buildChainReceipt(TransactionReceipt receipt) {
Expand Down
Loading